[PATCH] D92215: [WebAssembly] MC layer writes table symbols to object files

[Andy Wingo via Phabricator via llvm-commits]

wingo added a comment.

In D92215#2505347 <https://reviews.llvm.org/D92215#2505347>, @dmajor wrote:

> Hi, after this commit our builds of wasi-sdk have broken because wasi-libc's makefile [1] finds an undefined symbol for `__indirect_function_table` that wasn't in its expected list [2].
>
> Just to check, is this intended? Does the undefined-symbols.txt need an update?
>
> [1] https://github.com/WebAssembly/wasi-libc/blob/master/Makefile#L506
> [2] https://github.com/WebAssembly/wasi-libc/blob/master/expected/wasm32-wasi/undefined-symbols.txt

Yeah as @sbc100 says, this is intended -- object files now can have table symbols, and if the compilation unit takes the address of a function or makes an indirect call, it will have a `__indirect_function_table` symbol.  So the expectations need updating; sorry for the bother!

Note that this could happen again in the future if/when multiple memory support is added, for memory symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92215/new/

https://reviews.llvm.org/D92215