[PATCH] D93912: [libc++][P1679] add string contains

Mon Jan 18 23:59:00 PST 2021

WimLeflere added a comment.

In D93912#2505421 <https://reviews.llvm.org/D93912#2505421>, @Quuxplusone wrote:

> @ldionne: LGTM except that the non-constexpr tests no longer need to `return true;` from `bool test()` — they could do `void test()` for now.
> Also, I don't think this will rebase as-is on generate_feature_test_macro_components.py, will it? You'll have to add the entry for `__cpp_lib_string_contains`, which will be easy — but I notice that it //will// be a divergence from what's literally in https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations as of this writing. I would bet that's fine; I'm just bringing it up for awareness.
>
> The current direction on constexpr/noexcept sounds great to me.

The entry for `__cpp_lib_string_contains` in generate_feature_test_macro_components.py was already added in D94227 <https://reviews.llvm.org/D94227>, but I can rebase anyway.

https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations seems out of date anyway, the draft standard is maybe a better source?
https://eel.is/c++draft/version.syn

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912