[PATCH] D94821: [flang][directive] Get rid of flangClassValue in TableGen

[sameeran joshi via Phabricator via llvm-commits]

sameeranjoshi added inline comments.


================
Comment at: llvm/test/TableGen/directive2.td:17
 
 def TDLC_ClauseA : Clause<"clausea"> {
   let isImplicit = 1;
----------------
clementval wrote:
> clementval wrote:
> > sameeranjoshi wrote:
> > > Did you check with the target `check-llvm-tablegen` ?
> > I did it but will double-check. 
> All tests are passing on my side. What kind of error are you seeing? 
```
Command Output (stderr):
--
directive2.td:17:1: error: Record `TDLC_ClauseA' does not have a field named `flangClassValue'!

def TDLC_ClauseA : Clause<"clausea"> {
^
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/amd/f18_git/final_test/driver_build/bin/FileCheck -match-full-lines /home/amd/f18_git/final_test/llvm-project/llvm/test/TableGen/directive2.td -check-prefix=GEN
```

and for `directive1.td`.
```

Command Output (stderr):
--
/home/amd/f18_git/final_test/llvm-project/llvm/test/TableGen/directive1.td:97:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: llvm::StringRef getTdlAKindName(AKind);
```

I even rebased on `main` .
I have `gcc version 9.2.1`. Maybe that's the source of problem.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94821/new/

https://reviews.llvm.org/D94821