[PATCH] D94713: Do not traverse ConstantData use-list in SLPVectorizer

Anton Rapetov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 16:12:48 PST 2021


willir added a comment.

In D94713#2504342 <https://reviews.llvm.org/D94713#2504342>, @anton-afanasyev wrote:

> You are planning to revert this patch after `ConstantData` use-list removing, am I right?

Hi, well, not really, after `ConstantData` use-list removed, we definitely cannot walk its use-list.
We could change the check from `isa` to calling `hasUseList()`, but I'm not sure if it would be more readable here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94713/new/

https://reviews.llvm.org/D94713



More information about the llvm-commits mailing list