[PATCH] D94711: [PowerPC] Fix the check for the instruction using FRSP/XSRSP output register

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM with a couple more minor nits about the test case.



================
Comment at: llvm/test/CodeGen/PowerPC/non-debug-mi-search-frspxsrsp.ll:56
+
+attributes #0 = { nofree norecurse nounwind uwtable "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="ppc64le" "target-features"="+altivec,+bpermd,+crypto,+direct-move,+extdiv,+htm,+power8-vector,+vsx,-float128,-power9-vector,-spe" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nofree nosync nounwind readnone speculatable willreturn }
----------------
The extraneous attributes can be removed. You only need `nounwind` for `#0` and you don't need `#1` at all.


================
Comment at: llvm/test/CodeGen/PowerPC/non-debug-mi-search-frspxsrsp.ll:64
+!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 12.0.0", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, retainedTypes: !3, splitDebugInlining: false, nameTableKind: None)
+!1 = !DIFile(filename: "../test.c", directory: "../GitHub/llvm-on-power/Benchmarks/FFMPEG")
+!2 = !{}
----------------
The directory may lead someone to conclude that the test case comes from FFMPEG based on the directory you happen to have the file. However this is not the case, please remove the directory name to avoid confusion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94711/new/

https://reviews.llvm.org/D94711