[PATCH] D94862: [InstCombine] Replace one-use select operand based on condition

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 14:24:12 PST 2021


aqjune added a comment.

Hmm, would the pointer replacement be problematic here?
If there is a reduced version of a code, I think we can try

  -    if (isa<Constant>(CmpRHS) && !isa<ConstantExpr>(CmpRHS))
  +    if (isa<Constant>(CmpRHS) && !isa<ConstantExpr>(CmpRHS) && CmpRHS->getType()->isIntOrIntVectorTy())

and see whether the crash goes away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94862/new/

https://reviews.llvm.org/D94862



More information about the llvm-commits mailing list