[PATCH] D94866: [ValueTracking] Strengthen impliesPoison reasoning
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 18 14:20:02 PST 2021
aqjune accepted this revision.
aqjune added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:790
+}
+
TEST_F(ValueTrackingTest, ComputeNumSignBits_Shuffle_Pointers) {
----------------
nikic wrote:
> aqjune wrote:
> > Shall we have one more example that has EXPECT_FALSE because ValAssumedPoison was e.g. `icmp eq %x, %z` where z wasn't used by A?
> I think this case is checked by the existing impliesPoisonTest_ICmpUnknown test. It uses `icmp eq i32 %x, %y` and `icmp eq i32 %x, 1`.
+1
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94866/new/
https://reviews.llvm.org/D94866
More information about the llvm-commits
mailing list