[PATCH] D94929: [docs] Fix overly specific link to uploading patches on Phabricator

[Louis Dionne via Phabricator via llvm-commits]

ldionne created this revision.
ldionne added a reviewer: fhahn.
Herald added a subscriber: jkorous.
ldionne requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The documentation for contributing to LLVM currently links to the section
explaining how to submit a Phabricator review using the web interface.
I believe it would be better to link to the general page for using
Phabricator instead, which explains how to sign up with Phabricator,
and also how to submit patches using either the web interface or the
command-line.

I think this is worth changing because what currently *appears* to be our
preferred way of submitting a patch (through the web interface) isn't
actually what we prefer. Indeed, patches submitted from the command-line
have more meta-data available (such as which repository the patch targets),
and also can't suffer from missing context.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94929

Files:
  llvm/docs/Contributing.rst


Index: llvm/docs/Contributing.rst
===================================================================
--- llvm/docs/Contributing.rst
+++ llvm/docs/Contributing.rst
@@ -90,7 +90,7 @@
 
 To get a patch accepted, it has to be reviewed by the LLVM community. This can
 be done using `LLVM's Phabricator`_ or the llvm-commits mailing list.
-Please  follow :ref:`Phabricator#requesting-a-review-via-the-web-interface <phabricator-request-review-web>`
+Please  follow :ref:`Phabricator#code-reviews-with-phabricator>`
 to request a review using Phabricator.
 
 To make sure the right people see your patch, please select suitable reviewers


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94929.317406.patch
Type: text/x-patch
Size: 633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210118/bd45cf0a/attachment.bin>