[PATCH] D93789: Add accessors for MCSubtargetInfo CPU and Feature tables

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D93789#2503709 <https://reviews.llvm.org/D93789#2503709>, @craig.topper wrote:

> I’m not against this, but do want to mention the help text is incorrect for x86-64. It lists CPUs that don’t support 64-bit. Using one of those CPUs will trigger a fatal error. A better list is fillValidCPUList from X86TargetParser.cpp in lib/Support. It takes a mode argument. That’s the interface clang uses.

The fillValidCPUArchList() interface looks pretty annoying in that it's non-virtual. One needs to call different helper functions for each target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93789/new/

https://reviews.llvm.org/D93789