[PATCH] D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:923
+        // 'Parallel' constructs
+        llvm::omp::Directive currentDir;
+        const OmpDirectiveSet parallelDirSet{
----------------
praveen wrote:
> kiranchandramohan wrote:
> > Should this be set to some invalid value to avoid a stale value matching, since only block, loop and sections construct is handled for setting the currentDir?
> @kiranchandramohan Can the currentDir be set to **llvm::omp::Directive::OMPD_unknown** or is it used for a specific purpose ?
I think it is OK to use.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93091/new/

https://reviews.llvm.org/D93091