[PATCH] D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct
Kiran Chandramohan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 18 08:23:13 PST 2021
kiranchandramohan added inline comments.
================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:923
+ // 'Parallel' constructs
+ llvm::omp::Directive currentDir;
+ const OmpDirectiveSet parallelDirSet{
----------------
Should this be set to some invalid value to avoid a stale value matching, since only block, loop and sections construct is handled for setting the currentDir?
================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:967
+ "SCALAR or ARRAY assignments, FORALL or WHERE statements, "
+ "FORALL, WHERE, ATMOIC, CRITICAL or PARALLEL constructs"_err_en_US);
+ }
----------------
Nit: Spelling ATOMIC
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93091/new/
https://reviews.llvm.org/D93091
More information about the llvm-commits
mailing list