[PATCH] D90948: [WebAssembly] call_indirect issues table number relocs

[Andy Wingo via Phabricator via llvm-commits]

wingo added a comment.

Thanks, will land tomorrow if no emscripten build problems.



================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.cpp:71
           I - Start == NumVariadicDefs) {
-        // Skip type and flags arguments when printing for tests
+        // Skip type and table arguments when printing for tests.
         ++I;
----------------
sbc100 wrote:
> Is this comment correct?  In the tests below it looks like the table operand is being printed.
I think the comment is correct because the exception applies only to the register form `CALL_INDIRECT`, not `CALL_INDIRECT_S`.  The stack form has always printed the type, for example, as defined in the `.td` file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90948/new/

https://reviews.llvm.org/D90948