[PATCH] D94869: [LV] Fix crash when computing max VF too early

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 06:47:13 PST 2021


c-rhodes added a subscriber: fhahn.
c-rhodes added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5534-5535
   if (!useMaskedInterleavedAccesses(TTI)) {
     assert(WideningDecisions.empty() && Uniforms.empty() && Scalars.empty() &&
            "No decisions should have been taken at this point");
     // Note: There is no need to invalidate any cost modeling decisions here, as
----------------
@fhahn Any thoughts on this? This assert is firing since D90687, details above. I'm just wondering having looked at your patch D78298 if there's a more sensible fix here, maybe to get rid of the assert and call `invalidateCostModelingDecisions`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94869/new/

https://reviews.llvm.org/D94869



More information about the llvm-commits mailing list