[PATCH] D92934: [ARM][MachineOutliner] Add stack fixup feature.

[Sam Parker via Phabricator via llvm-commits]

samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5899
+
+  switch (AddrMode) {
+  case ARMII::AddrMode3:
----------------
yroux wrote:
> samparker wrote:
> > How about extracting this out into ARMBaseInstrInfo? There seems to be a fair number of places in the backend where getting the NumBits and Scale comes up.
> Yes I was thinking of that kind of refactoring and I'll look at it, now if you are ok with that peace of code, what about committing it as it is such that we can have full version of the machine outliner in LLVM-12.  And I'll propose a refactoring patch ASAP (since will touch BaseRegisterInfo, ConstantIsland, etc... I guess it will take some time to validate it properly)
Okay, sounds fair enough to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92934/new/

https://reviews.llvm.org/D92934