[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 18 00:55:43 PST 2021


mkazantsev added a comment.

This is awesome. And scary. This is scarily awesome. :)



================
Comment at: llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp:263
                                 const SimplifyCFGOptions &Options) {
-  assert((!RequireAndPreserveDomTree ||
-          (DT && DT->verify(DominatorTree::VerificationLevel::Full))) &&
----------------
Why remove that? It looks useful to have (maybe over-paranoid) checks that DT is correct at least for the first time. I'd rather keep them for a while unless there is a reason to drop them now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94827/new/

https://reviews.llvm.org/D94827



More information about the llvm-commits mailing list