[PATCH] D94560: [ELF] report section sizes when output file too large

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D94560#2502703 <https://reviews.llvm.org/D94560#2502703>, @inglorion wrote:

> Thanks again.
>
> I chose DAG on purpose because I think it more accurately expresses what we're really asserting.
>
> First, we since we removed the sorting, we're not guaranteeing that these will be in any particular order. Given that, I would rather not make the test depend on the order.

Actually we give a guarantee: the order of output sections must be stable. When using `-NEXT` we verify that we print section sizes in the same order as they present in the file.
Using `-DAG` relaxes this check. Also it makes the test case to look like we have a sorting, though we don't.

So, personally I also think that using `-NEXT` is would be better here. Also wonder what @jhenderson thinks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94560/new/

https://reviews.llvm.org/D94560