[PATCH] D94726: [X86] Add segment and address-size override prefixes

Mon Jan 18 00:17:14 PST 2021

skan accepted this revision.
skan added a comment.
This revision is now accepted and ready to land.

LGTM.  Before this patch, we could only write code like

  CS
  insl

`addr32/addr16` and `CS/DS/ES/FS/GS/SS` are prefixes, so they should be  allowed to be written before the instruction in the same line,  and GNU-AS does support this syntax.
One behavior different from GNU-AS is that `as` rejects `es` and  `ss` in 64-bit mode, but this has beyond the purpose of this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94726/new/

https://reviews.llvm.org/D94726