[PATCH] D94771: [Object, llvm-readelf] - Move the API for retrieving symbol versions to ELF.h

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Mostly looks fine. It might be nice if we could avoid putting so much code in the ELF.h header file, but that would require more refactoring, so we probably want to leave that to another patch.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/verdef-invalid.test:277
 # INVALID-VERDEF-GNU-NEXT:  Addr: 0000000000000000  Offset: 0x000040  Link: 3 (.dynsym)
-# INVALID-VERDEF-GNU-NEXT: warning: '[[FILE]]': unable to get a version for entry 1 of SHT_GNU_versym section with index 1: invalid SHT_GNU_verdef section with index 2: version definition 1 goes past the end of the section
+# INVALID-VERDEF-GNU-NEXT: warning: '[[FILE]]': invalid SHT_GNU_verdef section with index 2: version definition 1 goes past the end of the section
 # INVALID-VERDEF-GNU-NEXT:   000: 0 (*local*) 2 (<corrupt>)
----------------
What's happened to these error messages?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94771/new/

https://reviews.llvm.org/D94771