[PATCH] D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

some comments inline, lgtm otherwise



================
Comment at: llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp:570
+  // Update call site info for the Branch.
+  if (ToErase->isCall())
+    ToErase->getMF()->moveCallSiteInfo(ToErase, cast<MachineInstr>(&*Branch));
----------------
Should we use the `shouldUpdateCallSiteInfo()` predicate instead?


================
Comment at: llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp:572
+    ToErase->getMF()->moveCallSiteInfo(ToErase, cast<MachineInstr>(&*Branch));
   std::next(Branch)->eraseFromParent();
   return Branch;
----------------
nickdesaulniers wrote:
> Do you want to use
> 
>     ToErase->eraseFromParent();
> 
> here?
+1


================
Comment at: llvm/test/DebugInfo/MIR/Mips/call-site-info-update-delay-slot-filler.mir:33
+  
+  attributes #0 = { nounwind "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="mips32r6" "target-features"="+mips32r6,-noabicalls" "unsafe-fp-math"="false" "use-soft-float"="false" }
+  
----------------
Do we need all these attributes? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94685/new/

https://reviews.llvm.org/D94685