[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

As the discussion is spread out across multiple threads, do I understand correctly that the current consensus is to introduce the `-disable-noundef-analysis` flag, and explicitly add it to all the relevant tests (rather than adding it to the substitutions)?

In any case, I'd recommend changing this patch to default `-disable-noundef-analysis` to true (so you need to compile with `-disable-noundef-analysis=0` to get undef attributes). The flag can then be flipped together with the test changes. That should help get the main technical change landed directly, and avoid the need of landing patches at the same time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81678/new/

https://reviews.llvm.org/D81678