[PATCH] D94228: [flang][driver] Support fixed form detection

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 23:44:28 PST 2021


sameeranjoshi accepted this revision.
sameeranjoshi added a comment.
This revision is now accepted and ready to land.

Thank you for working on this.
It build and tests successfully.
Please wait for other reviewers to accept.



================
Comment at: flang/include/flang/FrontendTool/Utils.h:17
 
+#include "llvm/ADT/StringRef.h"
+
----------------
Do you really need this?


================
Comment at: flang/lib/Frontend/FrontendAction.cpp:13
+#include "flang/FrontendTool/Utils.h"
+#include "llvm/ADT/StringRef.h"
 #include "llvm/Support/Errc.h"
----------------
Is this really needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94228/new/

https://reviews.llvm.org/D94228



More information about the llvm-commits mailing list