[PATCH] D94726: [X86] Add segment and address-size override prefixes

[Bill Wendling via Phabricator via llvm-commits]

void added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:180-182
+                      Requires<[In32BitMode]>;
+def ADDR32_PREFIX : I<0x67, PrefixByte, (outs), (ins), "addr32", []>,
+                      Requires<[In64BitMode]>;
----------------
skan wrote:
> A minor suggestion: Add tests to check the predicates "In32BitMode", "In64BitMode" for addr16/32.
The tests which include ".code16"/".code32", etc., should be doing this already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94726/new/

https://reviews.llvm.org/D94726