[PATCH] D94765: [WIP]Expand masked mem intrinsics correctly wrt big-endian

Markus Lavin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 23:32:03 PST 2021


markus added a comment.

In D94765#2503378 <https://reviews.llvm.org/D94765#2503378>, @dmgreen wrote:

> Thanks for the patch. There is a patch to make MVE consistent with the rest of MVE in D94867 <https://reviews.llvm.org/D94867>. This will need rebasing on top of that, with update tests to make the two consistent again.

Thank you for looking into this.



================
Comment at: llvm/lib/Transforms/Scalar/ScalarizeMaskedMemIntrin.cpp:321-322
 
   // If the mask is not v1i1, use scalar bit test operations. This generates
   // better results on X86 at least.
   Value *SclrMask;
----------------
dmgreen wrote:
> It's a shame we can't just use extract elements - that would simplify this a lot!
> It's a shame we can't just use extract elements - that would simplify this a lot!

I fully agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94765/new/

https://reviews.llvm.org/D94765



More information about the llvm-commits mailing list