[PATCH] D92069: [NFC] [TargetRegisterInfo] add one use check to lookThruCopyLike.

[Jinsong Ji via Phabricator via llvm-commits]

jsji added a comment.

In D92069#2504002 <https://reviews.llvm.org/D92069#2504002>, @echristo wrote:

> I'd like to avoid the bool completely if possible.

Thanks @echristo for bring up this.  We are happy to change it for better code.

However, can you help us to understand the reason, and any advice about how to design this API?
Also is this PowerPC specific or general to LLVM coding style?

As we are seeing quite decent similar usages in the code base,
eg:

  $ grep "bool \*" llvm/include/llvm -R |wc
      53     332    5185

If this is general, do you think it worth mentioning in ProgrammersManual? 
If so, we can follow up a patch to update that as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92069/new/

https://reviews.llvm.org/D92069