[PATCH] D94866: [ValueTracking] Strengthen impliesPoison reasoning

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added a comment.

Okay, I agree that this is more general.
I was cautious about possible compile time degradation - do you have a number for this?



================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:783
+                "  %M2 = and i32 %x, 7\n"
+                "  %A2 = icmp eq i32 %x, 1\n"
+                "  %M = and i32 %x, 15\n"
----------------
Maybe `icmp eq i32 %M2, 1` here? (similarly below)


================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:790
+}
+
 TEST_F(ValueTrackingTest, ComputeNumSignBits_Shuffle_Pointers) {
----------------
Shall we have one more example that has EXPECT_FALSE because ValAssumedPoison was e.g. `icmp eq %x, %z` where z wasn't used by A?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94866/new/

https://reviews.llvm.org/D94866