[PATCH] D92069: [NFC] [TargetRegisterInfo] add one use check to lookThruCopyLike.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 17:33:34 PST 2021


shchenz added a comment.

In D92069#2503990 <https://reviews.llvm.org/D92069#2503990>, @echristo wrote:

> Sorry to point this out now, but taking a bool in/out pointer is some
> fairly awkward API. Can we do something else here?
>
> Thanks!
>
> -eric

Yes, I am happy to change this to another version. Do you think returning `std::pair<Register, bool>` is an acceptable way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92069/new/

https://reviews.llvm.org/D92069



More information about the llvm-commits mailing list