[PATCH] D94739: ADT: Fix reference invalidation in SmallVector::emplace_back and the size+value version of SmallVector::assign

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 15:09:12 PST 2021


dexonsmith added a comment.

In D94739#2502527 <https://reviews.llvm.org/D94739#2502527>, @dexonsmith wrote:

> [...] maybe I can trigger [the] compile-time tracker myself [...]

Done (thanks @nikic for the help!); here are the results:
https://llvm-compile-time-tracker.com/compare.php?from=ceaf0110ff5e0c2de1f03d65d13703d34d0d5737&to=7301e35eb244bb26c17ca9280813db3d9727cdbd

Looks mostly in the noise to me, with minor improvements and regressions on a few metrics (vaguely more improvements than regressions). IMO, this is good to go from a compile-time perspective.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94739/new/

https://reviews.llvm.org/D94739



More information about the llvm-commits mailing list