[PATCH] D94874: [InstCombine] Transform abs pattern using multiplication to abs intrinsic (PR45691)

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp:375
+    Abs->takeName(&I);
+    return replaceInstUsesWith(I, Abs);
+  }
----------------
xbolva00 wrote:
> nikic wrote:
> > Doesn't just `return Builder.CreateBinaryIntrinsic` work here?
> void llvm::SymbolTableListTraits<ValueSubClass>::addNodeToList(ValueSubClass*) [with ValueSubClass = llvm::Instruction]: Assertion `!V->getParent() && "Value already in a container!!"' failed.
> 
Oh right. Thanks for checking.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94874/new/

https://reviews.llvm.org/D94874