[PATCH] D93789: Add accessors for MCSubtargetInfo CPU and Feature tables

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 17 01:51:55 PST 2021


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. I'm not particularly familiar with this code, but don't see an issue with exposing this information. Currently MCSubtargetInfo directly incorporates the logic for printing a help text to the error stream, which is very dubious design. It should be possible to obtain the same information for printing a help text manually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93789/new/

https://reviews.llvm.org/D93789



More information about the llvm-commits mailing list