[PATCH] D94387: Add new LLVMComponents CMake module.

[Stella Laurenzo via Phabricator via llvm-commits]

stellaraccident added a comment.

Hi serge-sans-paille, thank you for the comments! They caught me mid-cleanup so, I decided to push a revision with the further minimal changes needed to get the build mostly functional with this facility, as I think it might provide some better context.  Now that I've got the tree in a non-hacky building mode and just have a handful of failing tests (around llvm-config mostly), I'll work through your comments a bit.

Note that as I was making the updates, the stricter arrangement actually flagged most of the issues, so finding/fixing was not too bad (for this most recent iteration -- my previous attempts were very hacky and hard). As I was making changes, I took notes on the things that still need doing: https://gist.github.com/stellaraccident/47b3ed28b8134bb0b6db2afbec7fc789

I'm still not exactly sure what the right development flow for this kind of change is. My current thought is to spend a few more iterations to make it fully functional (right now LLVM and MLIR build in both static and dynamic mode on Linux with just an X86 target, and just a few llvm-config tests are failing (expected)), and keep tracking head as I do it. Then when it seems in reasonable shape, see what dimensions we can slice it on safely for submission. Prior to that last part, I will need more community involvement to identify platforms and configurations that are important to validate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94387/new/

https://reviews.llvm.org/D94387