[PATCH] D94155: [X86] Fix tile config register spill issue.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke marked an inline comment as done.
LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:325
+          if (MIVisited.count(&*I))
+            continue;
+          if (!I->isCall())
----------------
xiangzhangllvm wrote:
> If you don't want to re-iterate the handled instructions in the first BB, PLS re-consider of following changes:
> if (MIVisited.count(&*I)) {
>   MBBVisited.insert(MBB);
>   break;
> }
I'd like to make it stable first, so I would make the logic as simple as possible. I prefer not judging the visited call to determine we terminate the iteration or not.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:350-351
+        // again.
+        if (Terminate)
+          break;
+        // Next we will iterate its predecessor.
----------------
xiangzhangllvm wrote:
>         if (Terminate || MBBVisited.count(MBB))
>           break;
The same reason, not count on visited call to terminate the iteration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94155/new/

https://reviews.llvm.org/D94155