[PATCH] D94155: [X86] Fix tile config register spill issue.

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:325
+          if (MIVisited.count(&*I))
+            continue;
+          if (!I->isCall())
----------------
If you don't want to re-iterate the handled instructions in the first BB, PLS re-consider of following changes:
if (MIVisited.count(&*I)) {
  MBBVisited.insert(MBB);
  break;
}


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:346-347
+        // a loop.
+        if (!First)
+          MBBVisited.insert(MBB);
+        // We encounter visited MachineInst, so we don't need to do backward
----------------
Pls move after line 358


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:350-351
+        // again.
+        if (Terminate)
+          break;
+        // Next we will iterate its predecessor.
----------------
        if (Terminate || MBBVisited.count(MBB))
          break;


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:359
+        }
+        First = false;
       }
----------------
        if (!First)
          MBBVisited.insert(MBB);
        First = false;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94155/new/

https://reviews.llvm.org/D94155