[PATCH] D94202: Preserve the lexical order of global variables during llvm-link merge

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: llvm/lib/Linker/IRMover.cpp:1477
+    // global variable.
+    auto *NewV = Mapper.mapValue(*GV);
+    if (InitCnst) {
----------------
Can we move this inside the condition below?


================
Comment at: llvm/lib/Linker/IRMover.cpp:1508
+
+      unsigned Size = OldElements.size();
+      while (Size > 0) {
----------------
use `erase`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94202/new/

https://reviews.llvm.org/D94202