[PATCH] D90687: [LV] Clamp VF hint when unsafe

Sat Jan 16 09:07:24 PST 2021

c-rhodes added a comment.

In D90687#2501881 <https://reviews.llvm.org/D90687#2501881>, @iajbar wrote:

> The patch that causes the assert is patch cba4accda08f90 <https://reviews.llvm.org/rGcba4accda08f90bbc96d7662ef6b1bb12a7733f2>. I tried commit c63799fc52ff247 <https://reviews.llvm.org/rGc63799fc52ff2473dc64cdbc343cefb8bb786b6b> that is before your patch and there is no assert. Thank you.

Apologies, I got this patch mixed up with D91718 <https://reviews.llvm.org/D91718>. You're right the crash is introduced by this patch. I've posted a fix D94869 <https://reviews.llvm.org/D94869>, see patch for more details.

Unrelated to this issue but might be of interest to you, I hit a crash:

  Loop IV: clang: /home/culrho01/llvm-project/llvm/include/llvm/Support/Casting.h:104: static bool llvm::isa_impl_cl<To, const From*>::doit(const From*) [with To = llvm::Instruction; From = llvm::Value]: Assertion `Val && "isa<> used on a null pointer"' failed.

when compiling your testcase with `-mllvm -debug`. Full invocation: `./bin/clang -Os -mhvx -fvectorize -mv67 ../testcase.c -S -o - -mllvm -debug`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90687/new/

https://reviews.llvm.org/D90687