[llvm] a61e42e - [NPM][Inliner] Temporarily remove inline_stats test case for always

Mircea Trofin via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 21:59:48 PST 2021


Author: Mircea Trofin
Date: 2021-01-15T21:59:35-08:00
New Revision: a61e42efbb73e55c44cbb0eb2686c7b4a25ca812

URL: https://github.com/llvm/llvm-project/commit/a61e42efbb73e55c44cbb0eb2686c7b4a25ca812
DIFF: https://github.com/llvm/llvm-project/commit/a61e42efbb73e55c44cbb0eb2686c7b4a25ca812.diff

LOG: [NPM][Inliner] Temporarily remove inline_stats test case for always
inline

The stats are printed at InlinePass destruction. When we have 2 of them,
it appears the destruction order of the Passes std::vector of the pass
manager differs in msan builds - example:
http://lab.llvm.org:8011/#/builders/74/builds/2135.

This reproes locally, too.

Temporarily removing the sub-test case, to green the build, and will
follow up with a stat dumping alternative that does not depend on vector
element dtor order.

Added: 
    

Modified: 
    llvm/test/Transforms/Inline/inline_stats.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/Inline/inline_stats.ll b/llvm/test/Transforms/Inline/inline_stats.ll
index 1d06ff5d533f..1553da04c7b6 100644
--- a/llvm/test/Transforms/Inline/inline_stats.ll
+++ b/llvm/test/Transforms/Inline/inline_stats.ll
@@ -9,9 +9,6 @@
 ; RUN: opt -S -passes=inliner-wrapper-no-mandatory-first -inliner-function-import-stats=basic < %s 2>&1 | FileCheck %s --check-prefixes=CHECK-BASIC,CHECK
 ; RUN: opt -S -passes=inliner-wrapper-no-mandatory-first -inliner-function-import-stats=verbose < %s 2>&1 | FileCheck %s --check-prefixes="CHECK-VERBOSE",CHECK
 
-; RUN: opt -S -passes=inliner-wrapper -inliner-function-import-stats=basic < %s 2>&1 | FileCheck %s --check-prefix=MANDATORY-FIRST
-; RUN: opt -S -passes=inliner-wrapper -inliner-function-import-stats=verbose < %s 2>&1 | FileCheck %s --check-prefix=MANDATORY-FIRST
-
 ; CHECK: ------- Dumping inliner stats for [<stdin>] -------
 ; CHECK-BASIC-NOT: -- List of inlined functions:
 ; CHECK-BASIC-NOT: -- Inlined not imported function
@@ -30,21 +27,6 @@
 ; CHECK: non-imported functions inlined anywhere: 1 [33.33% of non-imported functions]
 ; CHECK: non-imported functions inlined into importing module: 1 [33.33% of non-imported functions]
 
-; MANDATORY-FIRST: -- Summary:
-; MANDATORY-FIRST: All functions: 10, imported functions: 7
-; MANDATORY-FIRST: inlined functions: 4 [40% of all functions]
-; MANDATORY-FIRST: imported functions inlined anywhere: 3 [42.86% of imported functions]
-; MANDATORY-FIRST: imported functions inlined into importing module: 2 [28.57% of imported functions], remaining: 5 [71.43% of imported functions]
-; MANDATORY-FIRST: non-imported functions inlined anywhere: 1 [33.33% of non-imported functions]
-; MANDATORY-FIRST: non-imported functions inlined into importing module: 1 [33.33% of non-imported functions]
-; MANDATORY-FIRST: -- Summary:
-; MANDATORY-FIRST: All functions: 10, imported functions: 7
-; MANDATORY-FIRST: inlined functions: 1 [10% of all functions]
-; MANDATORY-FIRST: imported functions inlined anywhere: 1 [14.29% of imported functions]
-; MANDATORY-FIRST: imported functions inlined into importing module: 1 [14.29% of imported functions], remaining: 6 [85.71% of imported functions]
-; MANDATORY-FIRST: non-imported functions inlined anywhere: 0 [0% of non-imported functions]
-; MANDATORY-FIRST: non-imported functions inlined into importing module: 0 [0% of non-imported functions]
-
 define void @internal() {
     call fastcc void @external1()
     call fastcc void @internal2()


        


More information about the llvm-commits mailing list