[PATCH] D94857: [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC)

[Nathan Hawes via Phabricator via llvm-commits]

nathawes created this revision.
nathawes added reviewers: JDevlieghere, dexonsmith.
Herald added a subscriber: hiraditya.
nathawes requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As a fixme notes, both of these directory iterator implementations are conceptually similar and duplicate the functionality of returning and uniquing entries across two or more directories. This patch addresses the fixme by extracting their common functionality into a single class 'CombiningDirIterImpl'.

      

This also drops the 'Redirecting' prefix from RedirectingDirEntry and RedirectingFileEntry to save horizontal space. There's no loss of clarity as they already have to be prefixed with 'RedirectingFileSystem::' whenever they're referenced anyway.

      

rdar://problem/72485443


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94857

Files:
  llvm/include/llvm/Support/VirtualFileSystem.h
  llvm/lib/Support/VirtualFileSystem.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94857.317150.patch
Type: text/x-patch
Size: 24157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210116/d1ba0dd6/attachment.bin>