[PATCH] D94768: [AMDGPU] Implement mir parseCustomPseudoSourceValue

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMIRFormatter.cpp:22
+    const PseudoSourceValue *&PSV, ErrorCallbackType ErrorCallback) const {
+  if (Src == "TargetCustom7") {
+    const TargetInstrInfo *TII = MF.getSubtarget().getInstrInfo();
----------------
Isn't the point to stop using these meaningless names?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMIRFormatter.h:1
+//===-- llvm/CodeGen/MIRFormatter.h -----------------------------*- C++ -*-===//
+//
----------------
Filename copy paste


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94768/new/

https://reviews.llvm.org/D94768