[PATCH] D94834: [Coroutine] Do not CoroElide if there are musttail calls

Bruno Cardoso Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 17:17:38 PST 2021


bruno added a reviewer: bruno.
bruno added a comment.

Nice correctness improvement!



================
Comment at: llvm/lib/Transforms/Coroutines/CoroElide.cpp:259
+  for (Instruction &I : instructions(F))
+    if (auto *Call = dyn_cast<CallInst>(&I))
+      if (Call->isMustTailCall())
----------------
How about walking the BBs and check by using `getTerminatingMustTailCall()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94834/new/

https://reviews.llvm.org/D94834



More information about the llvm-commits mailing list