[PATCH] D94560: [ELF] report section sizes when output file too large

[Bob Haarman via Phabricator via llvm-commits]

inglorion added a comment.

Thanks again.

I chose DAG on purpose because I think it more accurately expresses what we're really asserting.

First, we since we removed the sorting, we're not guaranteeing that these will be in any particular order. Given that, I would rather not make the test depend on the order.

As for interleaving lines: we're not really guaranteeing there won't be any other sections, either. In fact, if I remove the parts that cause linking to fail, there is also a .comment section in the output.

So we want this to report at least the .text and .data section which are in the input, with the correct sizes, but we're not making any promises about these being the only sections or in which order the sections are listed. Which is exactly what DAG gives us.

Can we keep this as-is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94560/new/

https://reviews.llvm.org/D94560