[PATCH] D94822: [TableGen] Improve algorithm for inheriting class template arguments and fields

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:2628
+  } else {
+    assert(false && "invalid context for template argument");
   }
----------------
craig.topper wrote:
> llvm_unreachable
Or possibly drop the prior "if" and change it to an assert there.

ie change this:
```
...
else if (x) {
  ...
} else
  llvm_unreachable(...);
```

to this:
```
else {
  assert(x);
  ...
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94822/new/

https://reviews.llvm.org/D94822