[PATCH] D94708: [IR] Introduce llvm.experimental.vector.splice intrinsic

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/docs/LangRef.rst:16185
 
+'``llvm.experimental.vector.splice``' Intrinsic
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
----------------
Does this mention that %trailing.elt must be a constant?


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1638
+//===---------- Named shufflevector intrinsics ------===//
+def int_experimental_vector_splice : Intrinsic<[llvm_anyvector_ty],
+                                               [LLVMMatchType<0>,
----------------
Should this have DefaultAttrs?


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1258
+
+    setOperationAction(ISD::VECTOR_SPLICE, MVT::nxv2i1, Promote);
+    AddPromotedToType(ISD::VECTOR_SPLICE, MVT::nxv2i1, MVT::nxv2i64);
----------------
Can you use setOperationPromotedToType here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94708/new/

https://reviews.llvm.org/D94708