[PATCH] D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:33
+    "csprof-cold-thres", cl::init(100), cl::ZeroOrMore,
+    cl::desc("Specified the total samples threshold for a context profile to "
+             "be considered cold, any cold profiles will be merged into "
----------------
hoy wrote:
> Nit: Specify
> 
> I was wondering in the future if we'd like a consistent way of computing cold threshold with `SampleProfileSummaryBuilder`, i.e., counts below 99.9% (aka cut-off) are considered cold, so that the profile generator and the profile consumer will be on the same page.
Thanks for sharing this. I'm not sure how we get the 100 threshold, I guess this is the result of many iterations. Let me dig into the `SampleProfileSummaryBuilder` to see the chance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94111/new/

https://reviews.llvm.org/D94111