[PATCH] D94542: [X86] Default to -x86-pad-for-align=false to drop assembler difference with or w/o -g

Fri Jan 15 13:49:22 PST 2021

MaskRay added a comment.

In D94542#2501267 <https://reviews.llvm.org/D94542#2501267>, @reames wrote:

> In D94542#2500145 <https://reviews.llvm.org/D94542#2500145>, @MaskRay wrote:
>
>> The value of -mbranches-within-32B-boundaries also dilutes over time (it mitigates issues for some Skylake architectures).
>> (Surprising to me, this feature has been available for one year but I don't see a lot of adoption).
>
> The performance impact of the microcode fix were highly variable depending on the exact details of each workload.  Mostly barely moved, some really suffered.  I know of a couple of organizations using the mitigation, but I agree with your general point about this being something that decays in value with time.  Hopefully, in a few years, we can stop talking about this.

Yeah hopefully...

I'll push this tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94542/new/

https://reviews.llvm.org/D94542