[PATCH] D94756: [AMDGPU][MC][GFX10] Improved dpp8 errors handling

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 10:48:54 PST 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:7274
+    if (0 > Sels[i] || 7 < Sels[i]) {
+      Error(Loc, "expected a 3-bit value");
       return MatchOperand_ParseFail;
----------------
Just use getLoc() here? Loc does not seem to be used otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94756/new/

https://reviews.llvm.org/D94756



More information about the llvm-commits mailing list