[PATCH] D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions

Fri Jan 15 10:22:35 PST 2021

jrtc27 added a comment.

In D88385#2501562 <https://reviews.llvm.org/D88385#2501562>, @rengolin wrote:

> In D88385#2498908 <https://reviews.llvm.org/D88385#2498908>, @jrtc27 wrote:
>
>> Yeah my concern is not about m68k doing weird things, it's about the code that's added in the target-independent places to support m68k that I am most concerned with, as it affects every target regardless of whether m68k is enabled.
>
> Exactly, that's why I prefer to keep the CodeBeads implementation for now (that only affects the m68k target) than refactor table-gen (that would affect all).
>
> We should avoid mixing generic refactory with experimental code, unless the refactory is a clear benefit to all targets, not just the experimental one.
>
> I concur with @RKSimon that we should approve this code as is and get the target in.

That sounds reasonable (but +1 to @RKSimon 's comment about reviewing all this "special sauce" complexity before graduating from experimental)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88385/new/

https://reviews.llvm.org/D88385