[PATCH] D94800: ADT: Skip SmallVector::isReferenceToStorage when TakesParamByValue, NFC

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a reviewer: nikic.
dexonsmith added a subscriber: nikic.
dexonsmith added a comment.

In D94800#2501597 <https://reviews.llvm.org/D94800#2501597>, @dexonsmith wrote:

> Actually, I'm going to commit this immediately and not wait for review. Having caught up on my email that I missed yesterday, there's an active compile-time regression that this should fix. See https://reviews.llvm.org/D93779 for details.
>
> (Happy to respond to comments post-commit of course.)

Actually, no rush after all; the commits causing the compile-time regression were reverted in 33be50daa9ce1074c3b423a4ab27c70c0722113a <https://reviews.llvm.org/rG33be50daa9ce1074c3b423a4ab27c70c0722113a>.

@nikic, would you please check that this fixes the regression with the other three patches reapplied? (i.e., with 33be50daa9ce1074c3b423a4ab27c70c0722113a <https://reviews.llvm.org/rG33be50daa9ce1074c3b423a4ab27c70c0722113a> reverted?)

Assuming that looks good, I'll recommit the other three with this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94800/new/

https://reviews.llvm.org/D94800