[PATCH] D93779: ADT: Fix reference invalidation in SmallVector::push_back and single-element insert

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D93779#2499361 <https://reviews.llvm.org/D93779#2499361>, @nikic wrote:

> Over in D91837 <https://reviews.llvm.org/D91837> the reserveForAndGetAddress() implementation contained a check for TakesParamByValue that seems to be gone in this revision. My first guess is that this is the culprit, and we're now always performing the isReferenceToStorage() check.

Somehow I missed the replies here until now. I came across the same thing independently: https://reviews.llvm.org/D94800.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93779/new/

https://reviews.llvm.org/D93779