[PATCH] D94795: [AMDGPU] Fix use of HasModifiers in VopProfile

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin added a comment.

I would prefer to include HasClamp inside "field bit HasModifiers =" but VOPProfile allows clamp to be explicitly enabled through "bit _EnableClamp = 0" which still messes up the logic a little bit (like in class getIns64). Not sure if there is some other reason to keeping clamp separate from other modifiers.

This is why there are still a few "let HasClamp = 1;" lines. Ideally we would only want "= 0" for special cases where some modifiers are not used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94795/new/

https://reviews.llvm.org/D94795