[PATCH] D94547: [lld-macho] Run ObjCContractPass during LTO

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 09:07:52 PST 2021


int3 added inline comments.


================
Comment at: llvm/lib/LTO/LTOBackend.cpp:285
 
+  MPM.addPass(createModuleToFunctionPassAdaptor(ObjCARCContractPass()));
   MPM.run(Mod, MAM);
----------------
fhahn wrote:
> The reason this is not added to all backend pipelines is (presumably) that we do not want to run this unnecessarily on platforms that do not support ObjC. I think we should add a new flag to `lto::Config`, so users can request it. But as I mentioned below, I think it would be better to do it at the beginning of the codegen pass pipeline.
Isn't it technically possible for every platform to support ObjC, e.g. with GNUstep?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94547/new/

https://reviews.llvm.org/D94547



More information about the llvm-commits mailing list