[PATCH] D94783: [LTO] Remove options to disable inlining and GVNLoadPRE.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 07:49:30 PST 2021


fhahn created this revision.
fhahn added reviewers: steven_wu, tejohnson, dexonsmith, probinson.
Herald added subscribers: hiraditya, inglorion.
fhahn requested review of this revision.
Herald added a project: LLVM.

This patch removes some ancient options as a clean-up before moving
code-gen to use LTOBackend in D94487 <https://reviews.llvm.org/D94487>.

I think it would preferable to remove those ancient options, because

1. There are no corresponding options in LTOBackend based tools,
2. There are no unit tests for them,
3. They are not passed through by Clang,
4. At least for GNVLoadPRE, users could just use GVN's `enable-load-pre`.

Alternatively we could add support for those options to lto::Config &
co, but I think it would be better to remove them, unless they are
actually used in practice.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94783

Files:
  llvm/include/llvm/LTO/legacy/LTOCodeGenerator.h
  llvm/lib/LTO/LTOCodeGenerator.cpp
  llvm/tools/llvm-lto/llvm-lto.cpp
  llvm/tools/lto/lto.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94783.316955.patch
Type: text/x-patch
Size: 7371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210115/c4c75cfa/attachment.bin>


More information about the llvm-commits mailing list